[MPlayer-dev-eng] [PATCH] Doxygenize loader/dshow/output.c (cosmetics) and renaming some methods' names

[Guillaume POIRIER]

Hi,

On 1/16/07, Vladimir Voroshilov <voroshil at gmail.com> wrote:
> Hi,All
> First patch (outputpin_doxygen.c.diff) adds doxygen docs for
> loader/dshow/output.c, desribing what methods should do, it's
> parameters and possible return values.
> Info was got from DirectDshow DDK documentation.
>
> Second patch (outputpin_rename.c.diff) renames methods' names and
> debug printf according to documentation/behaviour.
>
> Patches are dependent of each other and can be applyed only in proper order.

Index: outputpin.c
===================================================================
--- outputpin.c	(revision 21937)
+++ outputpin.c	(working copy)
@@ -11,17 +11,16 @@
 #include <string.h>
 #include <stdlib.h>

-/*
-    An object beyond interface IEnumMediaTypes.
-    Returned by COutputPin through call IPin::EnumMediaTypes().
-*/
-
  static inline int output_unimplemented(const char* s, void* p)
 {
     Debug printf("%s(%p) called (UNIMPLEMENTED)", s, p);
     return E_NOTIMPL;
 }

+/*
+    An object beyond interface IEnumMediaTypes.
+    Returned by COutputPin through call IPin::EnumMediaTypes().
+*/
  typedef struct CEnumMediaTypes
 {
     IEnumMediaTypes_vt* vt;

I guess it's a typo: This isn't a doxy-compatible comment. It should
be /** ... */


Other than that, all seems just fine. Commit in a few days if you
don't get further feedback.

Guillaume