[MPlayer-dev-eng] [PATCH] get rid of *void pointer arithemtic in libvo/fastmemcpy.h
Reimar Doeffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Jan 25 15:37:31 CET 2007
Hello,
On Thu, Jan 25, 2007 at 02:36:46PM +0100, Guillaume Poirier wrote:
> The attached patch does $SUBJ.
>
> It was spotted by Intel's C Compiler.
>
> As Michael is the one who suggested that changed, unless someone
> disagrees or gives the go ahead now, I'll apply it by tomorrow.
>
> Guillaume
> Index: libvo/fastmemcpy.h
> ===================================================================
> --- libvo/fastmemcpy.h (revision 21941)
> +++ libvo/fastmemcpy.h (working copy)
> @@ -7,6 +7,7 @@
> #if defined(HAVE_MMX) || defined(HAVE_MMX2) || defined(HAVE_3DNOW) \
> /* || defined(HAVE_SSE) || defined(HAVE_SSE2) */
> #include <stddef.h>
> +#include <stdint.h>
I think inttypes.h is prefered within MPlayer even if it is not (yet)
needed here.
Also I do not like changing the type of the parameters, the memcpy types
are void*, too, AFAIK. Instead either cast or use a local variable with
appropriate type IMO
Greetings,
Reimar Döffinger
More information about the MPlayer-dev-eng
mailing list