[MPlayer-dev-eng] [PATCH] Filename double-conversion

[Rich Felker]

On Mon, Jan 15, 2007 at 01:46:05PM +0800, Zuxy Meng wrote:
> Hi,
> 
> 2006/12/28, Zuxy Meng <zuxy.meng at gmail.com>:
> >Hi,
> >
> >2006/12/22, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> >> Hello,
> >> On Fri, Dec 22, 2006 at 08:56:02PM +0800, Zuxy Meng wrote:
> >> > 2006/11/16, Zuxy Meng <zuxy.meng at gmail.com>:
> >> > >Sorry, my mistake. This one should be OK.
> >> >
> >> > Compn has kindly helped me test this patch and it worked well on his
> >> > machine: filename that used to be mess turned out to be meaning full
> >> > with proper locale or MPLAYER_CHARSET setting. As for what Reimar
> >> > concerned about (filename length throttling) maybe we can deal with
> >> > the general case in mp_msg() (cut off a message if it's too long and
> >> > append '...' to the end).
> >>
> >> I don't think that's necessary to handle explicitly, I was just
> >> collecting advantages of not using PATH_MAX.
> >
> >Then pls kindly review this one, using MSGSIZE_MAX instead of
> >unpredictable PATH_MAX, and append '...' to the end when the
> >filename's too long.
> 
> I hope someone could comment on this patch to see if it's ready for
> commit; it really means something for CJK users. Thanks!

yes, sorry for the insanely long delay. i've read the patch and as far
as i can tell, it should be correct and should at least work as well
as or better than the current broken behavior in all cases. please
apply. if any problems turn up we can fix them later. i'll drink the
cola if anything goes wrong.

rich