[MPlayer-dev-eng] [PATCH] Teletext support try3 (1/5, core)

Vladimir Voroshilov voroshil at gmail.com
Sun Jul 15 19:31:59 CEST 2007


2007/7/15, Michael Niedermayer <michaelni at gmx.at>:
> Hi
>
>
> [...]
> > +    case TV_VBI_CONTROL_SET_PAGE:
> > +    {
> > +        int val=*(int *) arg;
> > +        if(val<0 || val>0x799)
> > +            return TVI_CONTROL_FALSE;
> > +        pthread_mutex_lock(&(priv_vbi->buffer_mutex));
> > +        priv_vbi->pgno = steppage(0, val);
>
> this is wrong, if the user asks for page =0x7AB then you should return
> that page and not another page
>
Quote from 2.1.4 of
http://homepage.ntlworld.com/kryten_droid/teletext/spec/teletext_spec_1974.htm:
=============QUOTE================
Neither type of Page selection should respond to Page number 'Units'
or 'Tens' in the range 10 to 15
=============QUOTE================
Should i totally ignore this or just return error instead of wrong
page in case when user asking for 10-15 as one of digits?

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719



More information about the MPlayer-dev-eng mailing list