[MPlayer-dev-eng] [PATCH] SUN XVR-100 VO driver 3. try

[Balatoni Denes]

Hi!

Wednesday 25 July 2007 22:56-kor Alban Bedel ezt írta:
> > I did try it, it was much slower, so I didn't like it. Maybe in the
> > future (btw it seems two vertical retraces are needed until the page
> > is flipped, and that is slow).
>
> You don't have to vsync the flip, it's probably preferable, but not
> requiered. However as Uoti pointed out you will need double buffer
> for a proper timing.

It has to wait for the retrace, otherwise after flip_page mplayer starts 
rendering in the backbuffer, but it is still shown -> ugly artifact. Triple 
buffering would help, but I think I will just leave it for now.

> > It works, but there is a pink stripe on the right side. So IMO the
> > user should choose whether he/she wants pink stripe (-vo
> > xover:xvr100) or unusably slow playback (-vo x11).
>
> Is the image scaled down or a part missing? If a part is missing I
> would not consider that usefull and imho config() should fail. But if
> it's scaled down, you could compute the effective size and pass it back
> to xover to allow it to correctly resize the window.

A part is missing. It is exactly as usefull as -vo x11 (have you seen hd video 
decoding + c scaler downscaling on an UltraSPARC - like a very very very slow 
slideshow). This is really my opinion, because changing config would be easy, 
but as I described, not wanted.

> > > This could be done with less code duplication.
> >
> > Like moving 15 trivial lines of code to a separate function? What's
> > the point of that?
>
> How trivial it is doesn't matter imho, as soon as it exceed 2 or 3
> lines duplicated code just make maitenance harder.

Ok, so it will be moved into a separate function.

> > > What is not working exactly?
> >
> > -vfm ffmpeg -dr always says "stride changed" or something like that
> > (I don't have the message at hand), and some frames are not shown.
>
> You probably hit this pb:
> http://article.gmane.org/gmane.comp.video.mplayer.devel/1130
> It's a limitation of lavc, if it work fine with TEMP buffers you
> should enable it imho.

Ok, great, probably this was it. But how can I test this TEMP buffer thing?

> 	Albeu

thanks
bye
Denes