[MPlayer-dev-eng] Per-file -loop option reset brokenness

Ivan Kalvachev ikalvachev at gmail.com
Fri Jun 15 19:14:56 CEST 2007


2007/6/15, Uoti Urpala <uoti.urpala at pp1.inet.fi>:
> On Sat, 2007-06-09 at 21:43 +0300, Uoti Urpala wrote:
> > When using -loop as a per-file option it's implemented as a seek back to
> > the start of the file, and the code also resets option variables when it
> > does the seek. Resetting the variables like that in the middle of
> > playback is wrong; it skips sanity checks which would normally be run in
> > initialization code, and changing the values might also require running
> > code.
> >
> > Is it OK to simply remove that option reset functionality, or does
> > someone rely on some part of it? If there are a few options that should
> > reset in typical use then those could be handled. With the current
> > architecture it is not practical to implement correct reset of all
> > options.
>
> If nobody here is aware of any current use which would rely on this
> option-reset functionality I'll remove it soon and see if that makes any
> users complain.

Show us the code.



More information about the MPlayer-dev-eng mailing list