[MPlayer-dev-eng] [PATCH 1/4] String handling audit/cleanup

[Alex Beregszaszi]

Hi,

> > in cpudetect.c:
> > 
> > -       sprintf(vendor,"%.4s%.4s%.4s",(char*)(regs+1),(char*)(regs
> > +3),(char*)(regs+2));
> > +       snprintf(vendor, sizeof vendor, "%.4s%.4s%.4s",(char*)(regs
> > +1),(char*)(regs+3),(char*)(regs+2));
> > 
> > change this to sizeof(vendor)
> 
> Is there a reason you prefer this style? It's correct as written.
> Parentheses with sizeof are for sizeof(type) as opposed to
> sizeof lvalue.

Consistency to other parts of the code. We use sizeof() in ffmpeg and
mplayer.

--
Alex Beregszaszi