[MPlayer-dev-eng] [PATCH] get rid of lots of useless/duplicate code in vo_xv/vo_xvmc

[Reimar Döffinger]

Hello,
On Tue, Mar 06, 2007 at 04:55:06PM +0200, Ivan Kalvachev wrote:
> 2007/3/6, Ivan Kalvachev <ikalvachev at gmail.com>:
> >2007/3/6, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
[...]
> >> Well, I can at least pass around pointers to the global variable as in
> >> attached patch, if you prefer that.
> >> In the long term a vo struct would be nice, but that is a much bigger
> >> change to do in a useful way and would be overkill for passing around to
> >> such a simple function, too.
> >> Btw. should I attempt moving the code shared between those two vos to
> >> a xvideo.c (or similar)? At least most of config could be put there I
> >> think (though not sure how ugly it would get with all those globals).
> >
> >Don't move it, I have a cropping patch that may need to mess these for
> >xvmc case.
> >I'll do some xvmc stuff after I finish with my current project.

Ok, we'll see if there's enough common code left after that ;-)

> Patch OK to commit.

Done.

Greetings,
Reimar Döffinger