[MPlayer-dev-eng] [PATCH] VCD support for Windows (except Win9x)

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Mar 9 13:04:26 CET 2007


Hello,
On Wed, Feb 28, 2007 at 04:10:15PM +0800, Zuxy Meng wrote:
> +#ifdef WIN32
> +  device[4] = p->device[0];
> +  hd = CreateFile(device, GENERIC_READ, FILE_SHARE_READ, NULL,
> +	  OPEN_EXISTING, FILE_FLAG_SEQUENTIAL_SCAN, NULL);
> +  /* It's safe here: when f gets close()'ed, hd will be released too. */
> +  f = _open_osfhandle((long)hd, _O_RDONLY);

Not really important, but I don't quite understand what the comment is
supposed to mean. A comment why CreateFile is needed and a "normal" open
does not work might be interesting, too.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list