[MPlayer-dev-eng] [PATCH] Zattoo
Vladimir Serbinenko
phcoder at gmail.com
Sat Mar 10 11:56:39 CET 2007
Hello. First of all I really want to excuse myself about the ugliness.
It's issued from reverse engeneering (so by trying). And as soon as I
finished I sent it to the list.
Second thing: unfortunately it logged in only if your username had the
same length as mine (13 bytes). I fixed it and send new patch
Nico Sabbi wrote:
> Vladimir Serbinenko wrote:
>> I send now the patch supporting logging in. Now the syntax is
>> mplayer ztvhttp://<username aka email>:<md5 of your password>:<channel>
>> For the list of the channels see my previous mail. As you can see in
>> patch it's quite uncomplete (All the FIXMEs). The field I don't know
>> much about are named sth[number]. The field serving for identifiing or
>> set to constant values are named magick<number>. /*TORES*/ means that
>> this field could be something else. In short it just works, nothing
>> more.
>> Vladimir 'phcoder' Serbinenko
>>
>
> doing a quick scroll of your patch I noticed that theres not a single
> comment!
> A good patch should include descriptions of the working principle and
> of the individual functions, otherwise reviewing code 1 month from now
> will be impossible.
I'll add some comments
> There are also a lot of printf() that should be replaced with mp_msg().
>
I know it's one of my "FIXME". As I said its' very raw
> I also have some questions:
> - what demuxer does this stream require?
They use their own demuxer incorporating some ciphering (RSA+AES) and to
ask the key it requires side query and you can't decipher without
demuxing so I create matroska on the fly
> - are you sure that out http functions can't (at least partly) be reused?
No it's not a real http. (I had some problem with its strangeness). It
has to be created by very primitive functions.
> - what's the content of this stream? matroska with some fixed codecs?
>
It's h264 and aac incapsulated in some kind of their own encapsulation
and encryption format but when you do -dumpstream you receive matroska.
Thanks for the comments
Vladimir 'phcoder' Serbinenko
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mplayer5.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070310/da43eb77/attachment.asc>
More information about the MPlayer-dev-eng
mailing list