[MPlayer-dev-eng] [PATCH] VCD support for Windows (except Win9x)

[Compn]

On Mon, 12 Mar 2007 18:44:13 +0100, 
Diego Biurrun scribed:

> On Mon, Mar 12, 2007 at 04:56:43PM +0100, Diego Biurrun wrote:
> > On Mon, Mar 12, 2007 at 10:57:50AM -0500, Compn wrote:
> > > 
> > > thanks, applied.
> > 
> > Why did you split the patch into multiple commits?


forgot that svn accepts multiple filenames...


> I see that the policy is unclear about this issue ..
> 
> Benjamin, never split patches by file or directory.  Commits should be
> logical units.  If a patch can be split *logically* into smaller
> pieces, then it's fine and even beneficial to spread them over
> multiple commits. Otherwise maintain the parts together.
> 
> It's quite possible that some revisions don't compile anymore now.


now i know... wont happen again.

-compn