[MPlayer-dev-eng] Re: libdvdnav
Diego Biurrun
diego at biurrun.de
Thu Mar 15 12:03:01 CET 2007
On Wed, Mar 14, 2007 at 08:30:22PM +0100, Ötvös Attila wrote:
> 2007. március 14. 19.09 dátummal Diego Biurrun ezt írta:
> > On Wed, Mar 14, 2007 at 06:12:19PM +0100, ?tv?s Attila wrote:
> > > The 3-dvdnav.patch patch modifies the configure and Makefile so internal
> > > dvdnav can build.
>
> I correctioned this.
>
> --- configure (revision 22547)
> +++ configure (working copy)
> @@ -5181,15 +5199,32 @@
> + _def_dvdnav_sversion="#define DVDNAVSVERSION \"0.1.10\""
What's 'sversion' supposed to be? Please find a more descriptive
variable name.
> --- dvdnav/Makefile (none)
> +++ dvdnav/Makefile (working copy)
> @@ -0,0 +1,22 @@
> +
> +SRCS_COMMON += decoder.c \
> + dvdnav.c \
> + highlight.c \
> + navigation.c \
> + read_cache.c \
> + remap.c \
> + searching.c \
> + settings.c \
> + vm.c \
> + vmcmd.c \
Please align the sources.
> +CFLAGS = -I. -I.. -I../loader -DHAVE_CONFIG_H
Are all of these really needed? -I. and -I.. are in the default CFLAGS.
> +ifeq ($(DVDREAD_INTERNAL),yes)
> +INCLUDE += -I../dvdread -I../../dvdread
> +endif
There is no such thing as an INCLUDE variable, this is likely broken and
your intention was to add this to the CFLAGS. Use
CLAGS-($(DVDREAD_INTERNAL) += -I../dvdread -I../../dvdread
instead to achieve this, but do you need both ../ and ../../ ?
Diego
More information about the MPlayer-dev-eng
mailing list