[MPlayer-dev-eng] [PATCH] (De)activate pp with 'D'

[Rich Felker]

On Sun, Mar 18, 2007 at 01:28:49PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> On Sunday, 18 March 2007 at 10:28, Carl Eugen Hoyos wrote:
> > Hi!
> > 
> > Attached patch adds possibility to deactivate and reactivate pp video
> > filters (including deinterlacers) by pressing 'D'.
> > 
> > If no one objects, I'll commit after Wednesday.
> 
> What will happen if someone uses -vf kerndeint,pp=de for example? Do both
> filters get activated? IMHO if we start assigning keys to enable/disable
> filters, we'll run out of keys very quickly. I don't like this feature.

AFAIK deinterlace toggle already exists. kerndeint just was not
honoring it. IMO it's an ugly hackish feature that should never have
been added, but now that it's there it should at least be consistent
between filters.

Rich