[MPlayer-dev-eng] [PATCH] Remove ugly #include from tvi_bsdbt848.c

[Bernd Ernesti]

On Mon, Mar 19, 2007 at 06:54:31PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> On Monday, 19 March 2007 at 18:33, Vladimir Voroshilov wrote:
> > Hi, All
> > 
> > This patch removes ugly #include from *BSD bt848 tv driver
> > (proper header will be detected by configure).

It does not really check the correct headers, i fou had looked at your patch
then you would have noticed that you removed more then one header file.

> > Diego, what will you say?
> > 
> > Unfortunately, i havn't BSD, so can not make fine test for this patch.
> > But small synthetic test works.

This will not work if you don't have the real header files which depends
on other files or you need an extra header for another function in this
file.

> Looks good, but maybe add the found header name to output, something
> like
> checking for BSD bt848... yes (using header.blah)

That is another thing and then the patch is not good, see my above coments.

I can only do a test compile in 2 weeks time.

Bernd