[MPlayer-dev-eng] MinGW hack in libaf/Makefile

[Rich Felker]

On Wed, Mar 21, 2007 at 01:34:41AM +0100, Diego Biurrun wrote:
> > > The problem is that one filter (af_export) includes fcntl.h.  There open
> > > has been renamed to af_open already.  So we might as well be consistent.
> > 
> > IMO not. This is a very rare and special case (and probably one that
> > should never have been added in the first place). No need to rename
> > functions in tons of other files because a hackish special case
> > requires it. Aside from af_export, all the filters are plain C code,
> > not posix/unix-dependent stuff, so there's no reason they should avoid
> > the posix function name open.
> 
> IMO it's more hackish to have one filter use a different name, besides
> it's just too easy to have conflicts with a name like 'open'.  As soon
> as one of the audio filters gets modified and includes a header where
> open appears you're into this dance again.  I guess it's a matter of
> taste ...

A header that declares open should NEVER be included in portable C
code that's not posix-dependent. The conflict is actually nice because
it reveals this coding mistake. But I see you changed it anyway for no
good reason...

Rich