[MPlayer-dev-eng] [PATCH] TV teletext

[Vladimir Voroshilov]

2007/3/25, Ötvös Attila <oattila at chello.hu>:
> 2007. március 24. 09.04 dátummal Vladimir Voroshilov ezt írta:
> Hi Vladimir Voroshilov!
>
> I repair and cosmetics code.

This version is a bit better ;)
Thanks for removed tabs.
But...
Is this your preferredindentation style?
Well, i don't want to force you using not preferred style, but this is
really hard to read. If you wish i can make cosmetics patch.

Now about functionality.
Tested text,bw,gray modes.
All crashes are gone away.


> New function:
> - Use cache with libzvbi

Seems like libzvbi's internal cache is too smal (around 10 pages).
After skipping 10 (or so) pages and returning back i have to wait
again until scanner reaches this page. To avoid this pause i've
implemented full-size buffer to store all pages in memory (cache
member of priv_vbi_t structure). Backgound thread (grabber) updates
pages in this buffer all time mplayer is running once and once again.
and user must to wait only once when grabber does not cached all pages
yet.

What things were done (i have attached patchws, which should be
applied after your's).
1. process_page is splitted into
"process_page" (preparing page for drawing) and
"update_page" (checking pages in buffer and deciding whether page is
needed update or not)
2. removed page_decoded, act_pgno, act_subno (no longer needed)
3. simplified steppage. libzvbi already has vbi_bcd2dec and
vbi_dec2bcd routines for
convertin page number from hex into decimal and vice versa.

Look also  on subtitles decision algorithm (in process_page). With my
method when priv_vbi->half=2 page misdetects as subtitle page and i
can't see it until grabber refreshes it in cache.
Thereis either wrong decision or wrong rendering bottom of page
(header with page number is goes away when bottom half page is
displayed).


> - Switch white to black char in bw mode
> - Improved transparent mode
> - Show background in transparent mode if teletext page is subtitle
> - Display find page number

Thereis some strange behaviour in opaque bw/gray mode (white color is
not white, movie colors can be seen through white pixels).
See screenshot at
http://doors.univer.omsk.su/~v​oroshil/downloads/MPL2.png

>
> 'X': vbi_switch
> Text: on teletext -> off teletext
> Bw: opacity mode -> transparent mode with white char - > black char -> off
> Gray/color: opacity -> transparent -> off
>
> 'E': vbi_half_page
> Text: display bottom page -> display top page
> Bw/gray/color: bottom half page -> top half page -> full page

What about swapping 'W' and 'Q' keys?
'Q' present at the seft side of 'W'. So , due to  "left=less=previous"
and "right=more=next", binding 'Q' to prev page and 'W' to next page
sounds reasonable for me.

Also "make" after "./configure --disable-teletext" gives me "undefined
references" errors.

As i said earlier i can't review other parts. so i hope  other devs
will do this.


P.S. fix also typo in configure "--disable-tv-teletex" in help output
P.P.S. could you also post  small "colorspu" patch wich should be
applyed after "teletext" one.

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tvi_vbi.c.diff
Type: application/octet-stream
Size: 9863 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070325/05a74971/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tvi_vbi.h.diff
Type: application/octet-stream
Size: 794 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070325/05a74971/attachment-0001.obj>