[MPlayer-dev-eng] [PATCH] Add surround50 to autodetected devices

[Clemens Ladisch]

Piotr Kaczuba wrote:
> > This patch adds surround50 to the autodetected devices in
> > libao/ao_alsa.c so that the user doesn't have to specify it on the
> > command line when a file with 5 audio channels is played. Without the
> > patch or the appropriate command line option "default" (i.e. 2 channels)
> > is selected, which is clearly wrong.
> 
> Anyone wants to comment the patch?

Sorry, was on vacation and caught a virus.


Apart from the missing Changelog entry, the patch itself looks OK.

However, a five-channel audio file could have LFE as the fifth channel;
in that case, "surround41" would be the correct device to use.

The driver should select "surround41" or "surround50" depending on the
type of the fifth channel, but the current libao2 API doesn't allow to
detect this.

It would be possible to add a flag to the ao init() function, but this
would also require to change most audio demuxers to actually provide
this information, and if a demuxer doesn't know, we'd still have to
guess.


Regards,
Clemens