[MPlayer-dev-eng] RFC on libspe2 detection

Luca Barbato lu_zero at gentoo.org
Thu May 17 12:33:00 CEST 2007


Rasmus Rohde wrote:
>> - avoid unnecessary casts
> I've walked through the code and removed what I could find of unnecessary casts.

I think there are still some...

>> - why are you favoring the usage of the external program instead of the
>> embedded one? shouldn't be the opposite? (you fallback to the external
>> program only if you hadn't embedded the spu code?)
> If you have written super ultimate Vista scaler ++ 2.0 and want to use that
> instead, you can do it without recompiling mplayer.

A consisten way should be the one used by the vo_opengl, but could wait
for later.

>> - you could factorize some constants
> I probably could. That will have to wait.

I'll help =)

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero




More information about the MPlayer-dev-eng mailing list