[MPlayer-dev-eng] [PATCH] replace polyp- by pulseaudio ao

[Reimar Döffinger]

Hello,
On Sun, Oct 14, 2007 at 05:19:48PM -0400, The Wanderer wrote:
> Diego Biurrun wrote:
> > On Sun, Oct 14, 2007 at 02:27:03PM +0200, Reimar Döffinger wrote:
> > 
> >> polypaudio IMO is ancient enough so it can just be thrown away.
> >> Attached patch would replace it by pulseaudio (though maybe it
> >> would be better to do this in two steps, any objections against
> >> removing polypaudio right now?). I still think it is too huge for
> >> what it does, but I don't see any more ways to improve that right
> >> now.
> > 
> > Fine with me, pulseaudio is a much-requested feature.
> 
> I forget, and I don't remember when the original discussion took place -
> what were the reasons for refusing to switch over back when the request
> was first made (by, I think, the developers of the library), and why
> would they not apply now?

Polypaudio was not quite as dated back then. And we did not have Ubuntu
using that patch despite the fact that it completely breaks the Gui, so
adding a working version would at least get rid of some bug reports.

> I think the objections had something to do with API issues and/or
> senseless renaming... people were fairly adamant about rejecting the
> change at the time, IIRC.

The API is still horrible, but I now did some of the cleanup I requested
back then (not the stuff about renaming or merging with polypaudio I
requested back then, it does not seem appropriate anymore).
During that cleanup not only did the code size shrink by I think more
than 20% but I also found several bugs.
Lastly, I am confident that I can take over at least basic
maintainership, I am almost certain that had it been applied back then
it would have been left to rot, no matter how big the bugs, just as it
happened to polypaudio (ubuntu still not having fixed their patch
indicates to me that there is not as much interest in this as Diego
claims, not by far - I also have suggested to multiple people claiming
to want this feature to clean the patch up - to none it was important
enough to actually work on it. I did not even get any responses to the
request to test my git tree with it).

Greetings,
Reimar Döffinger