[MPlayer-dev-eng] [PATCH] fix numerous const issues in libmpcodecs

Diego Biurrun diego at biurrun.de
Fri Oct 19 11:29:20 CEST 2007


On Thu, Oct 18, 2007 at 03:58:34PM -0400, Rich Felker wrote:
> MPlayer has LOTS of issues with constant data tables which are not
> declared const. While this might or might not have impact on its
> memory usage (probably small if any), it's very unclean and makes it
> hard to use tools like 'size' to identify modules which are
> incorrectly using real global variables instead of per-context data.
> 
> The attached patch is the initial work towards fixing the problem in
> libmpcodecs. I'm submitting it now for comments before I go to lots
> more work, only to have someone bitch about why it's bad.. :) So
> please comment now. And if anyone would like to volunteer to finish
> the job so I don't have to, I'd be quite happy with that too. :))

Nice to see you back coding :)

This is probably good to commit right away.  And no, I don't think you
will find volunteers to finish the work you started ;-p

Diego



More information about the MPlayer-dev-eng mailing list