[MPlayer-dev-eng] [PATCH] bigendian fix for hwac3

[Reimar Döffinger]

Hello,
On Sat, Sep 15, 2007 at 04:51:33PM +0200, elupus wrote:
> > "Reimar Döffinger" <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote in 
> > message news:20070915081600.GB4535 at 1und1.de...
> > Hello,
> > On Sat, Sep 15, 2007 at 08:17:28AM +0800, Ulion wrote:
> > [...]
> > I made a patch according to your sample code, here it is.
> >
> > I already did this yesterday, but I lack information if the same is
> > necessary for AC3. And I am actually surprised that odd size is allowed
> > at all since both AC3 and DTS are formats based on 16bit samples AFAICT.
> > Btw.: the comment still didn't apply anymore, since the last byte was
> > copied with the code as is, it just wasn't copied the right way.
> 
> Actually it does still apply, as you copy it to the wrong location. If I 
> remember correctly your fix isn't enough, you have to pretend as if the 
> source was appended by a zero byte. when that is swabbed you end up with a 
> zero in secondlast byte and the last byte after that. Right now you just 
> added the last byte to the end of the swabbed structure. In essence the 
> result is one byte longer than the source.

And how does a comment saying "last byte is not copied" make sense or
help in any way when the problem is something completely different? IMO
not at all and that is what I meant when I said the comment does not
apply anymore.
Either way, I proposed a patch for this, so please test it so we can get
over with this.

Greetings,
Reimar Döffinger