[MPlayer-dev-eng] [PATCH] demux_lavf analyzeduration option + minor fixes

Diego Biurrun diego at biurrun.de
Fri Sep 28 19:30:29 CEST 2007


On Fri, Sep 28, 2007 at 07:18:10PM +0200, Jindrich Makovicka wrote:
> 
> The attached patches fixes minor issues with lavf demuxer:
> 
> 1) demux_lavf.c.fix.diff squishes one const cast warning, removes
> an useless conversion to double, because "probesize" is an integer
> option, and also fixes an invalid format string.

Separate commits for separate issues please.  The const warning fix
looks OK to me.

> 2) demux_lavf.c.analyzeduration.diff adds an "analyzeduration" option,
> which allows playback of otherwise unplayable files, where some
> of the tracks start later.
> 
> (eg. http://kmlinux.fjfi.cvut.cz/~makovick/tokyospeech.flv )

I guess this should go into the samples collection.

> 3) mplayer.1.diff adds "analyzeduration" and a missing "format"
> option to the man page.

Commit the description of format right away please.

> --- mplayer.1	(revision 24645)
> +++ mplayer.1	(working copy)
> @@ -10105,8 +10105,16 @@
>  In the case of MPEG-TS this value identifies the maximum number
>  of TS packets to scan.
>  .
> +.TP
> +.B analyzeduration=<value>
> +Maximum length in seconds to analyze the stream properties.
>  .
> +.TP
> +.B format=<value>
> +Force a specific libavformat demuxer.

Add them in alphabetical order please.

Diego



More information about the MPlayer-dev-eng mailing list