[MPlayer-dev-eng] libvo changes

[Ivan Kalvachev]

On Wed, Apr 2, 2008 at 9:29 PM, Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:
> On Wed, 2008-04-02 at 19:56 +0200, Reimar Döffinger wrote:
>  > On Wed, Apr 02, 2008 at 08:22:42PM +0300, Uoti Urpala wrote:
>
> > > I created these in preparation of creating a data struct for VOs, but
>  > > that isn't complete yet and I thought I'd post these first.
>  >
>  > I can't see how this would be related to creating a data struct for
>  > VOs...
>
>  I'm adding functions that forward their arguments, and variable
>  arguments make that harder.
>
>
>  > > -   return((video_out->control(VOCTRL_SET_EQUALIZER, eq->item, eq->value) == VO_TRUE) ? CONTROL_TRUE : CONTROL_FALSE);
>  > > +   return((video_out->control(VOCTRL_SET_EQUALIZER, VOCTRL_SET_EQUALIZER_ARGS(eq->item, eq->value)) == VO_TRUE) ? CONTROL_TRUE : CONTROL_FALSE);
>  > >      }
>  >
>  > Personally, I find this line rather too crowded as it is, a
>  > struct voctrl_set_equalizer_args param = {eq->item, &eq->value};
>  > in a extra line would look much better IMO.
>
>  I can change it to that, and the call perhaps further to
>
>         return video_out->control(VOCTRL_SET_EQUALIZER, &param) == VO_TRUE;

Please do. I think that we don't even need "struct
voctrl_set_equalizer_args" as it duplicates "vf_equalizer_t" from vf.h
.
It is probably better to do not have separate VOCTRL* and VFCTRL_*
stuff, either,  it is only adding confusion.

I'm ok with the rest of the patches.

To be honest I'm surprised that va_args control()s are still in
mplayer source, I though they have been removed long ago, but this is
probably true only for video filters.