[MPlayer-dev-eng] libvo changes

[Uoti Urpala]

On Sat, 2008-04-05 at 22:53 +0200, Reimar Döffinger wrote:
> On Sat, Apr 05, 2008 at 07:55:14PM +0300, Uoti Urpala wrote:
> > Here are the latest libvo changes. They add the basics of a new VO
> > driver API and convert vo_xv to use it.
> 
> And, if there are no objections, could you apply the first two patches
> (removing the control varargs) in the next few days so they can be
> tested and also the patchset gets smaller.

I don't think there is much need to test them separately. If we try to
get people using rare VO drivers to test they could as well test all the
changes.

> And yes, I still do intend to move declarations around so they are at a
> start of a block.

Insisting on changing every line in MPlayer to match your preferred
style is highly offensive behavior IMO. I don't demand that you write
everything in the style I want. Would you be happy if I start editing
all your commits?

Also from a practical POV I intend to make quite a few more changes (and
already have some queued), and I don't want to waste time resolving
conflicts caused by some pointless edits (plus probably resulting
flamewars too).

If you just can't live without editing everything to your own style at
least keep the changes in your private repo.

> I'd also rather like to do some cosmetics on video_out.c that mostly splits
> your patch (removing trailing whitespace, then consistent indentation
> for video_out_drivers), but I don't want to mess up your patch set, do
> you think I could do that without creating a mess for you?

I'm not quite sure what kind of changes you mean. There shouldn't be any
trailing whitespace in the current file; if you mean creating a separate
commit which does nothing but remove trailing whitespace, not even other
whitespace changes, I don't see the point (and especially not doing any
extra work for it).

> Similar question about doing strcasecmp -> strcmp for the equalizer
> stuff (though I think there is little conflict after the first two patches
> with these).

Any reason these couldn't come after the posted patches?