[MPlayer-dev-eng] libvo changes

[Diego Biurrun]

On Sun, Apr 06, 2008 at 02:19:44AM +0300, Uoti Urpala wrote:
> On Sat, 2008-04-05 at 22:53 +0200, Reimar Döffinger wrote:
> > And yes, I still do intend to move declarations around so they are at a
> > start of a block.
> 
> Insisting on changing every line in MPlayer to match your preferred
> style is highly offensive behavior IMO. I don't demand that you write
> everything in the style I want. Would you be happy if I start editing
> all your commits?
> 
> Also from a practical POV I intend to make quite a few more changes (and
> already have some queued), and I don't want to waste time resolving
> conflicts caused by some pointless edits (plus probably resulting
> flamewars too).
> 
> If you just can't live without editing everything to your own style at
> least keep the changes in your private repo.

*yawn* - the amount of boredom I feel just when thinking about this
topic again defies all measures...

> > I'd also rather like to do some cosmetics on video_out.c that mostly splits
> > your patch (removing trailing whitespace, then consistent indentation
> > for video_out_drivers), but I don't want to mess up your patch set, do
> > you think I could do that without creating a mess for you?
> 
> I'm not quite sure what kind of changes you mean. There shouldn't be any
> trailing whitespace in the current file; if you mean creating a separate
> commit which does nothing but remove trailing whitespace, not even other
> whitespace changes, I don't see the point (and especially not doing any
> extra work for it).

I personally would be in favor of removing all trailing whitespace from
non-imported code.  Don't worry, you will not have to do the work.

Diego