[MPlayer-dev-eng] [PATCH] Runtime colorful and/or module name output control

[Diego Biurrun]

On Wed, Apr 09, 2008 at 06:50:42PM +0800, Zuxy Meng wrote:
> 
> 2008/4/9, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > On Wed, Apr 09, 2008 at 04:25:07PM +0800, Zuxy Meng wrote:
> > >  void mp_msg(int mod, int lev, const char *format, ... ){
> > >      va_list va;
> > >      char tmp[MSGSIZE_MAX];
> > > +    FILE *stream= (lev) <= MSGL_WARN ? stderr : stdout;
> > > +    static int header=1;
> >
> > There are quite a few cosmetic or almost so changes in the following.
> > Maybe they are not worth avoiding, but then at least take the chance
> > to fix some more mess, like the useless () around the lev variable above
> > and the inconsistent placing of spaces before/after =.
> 
> OK. msgmod renamed to msgmodule and cleaning up in the attached.

OK

> --- mp_msg.c	?????? 26348??
> +++ mp_msg.c	????????????
> @@ -30,6 +27,8 @@
>  int verbose = 0;
> +int mp_msg_color = 0;
> +int mp_msg_mod = 0;

Could you please call this mp_msg_module?

> @@ -86,9 +85,92 @@
> +static void print_msg_mod(FILE* stream, int mod)

and print_msg_module here ..

> +    static const char *mod_text[MSGT_MAX] = {

module_text

This would make things more readable IMO.

Diego