[MPlayer-dev-eng] [PATCH] [RESEND] -aspect-tolerenace option

[Reimar Döffinger]

On Sat, Apr 12, 2008 at 01:58:10AM +0200, Kurt Garloff wrote:
> On Fri, Apr 11, 2008 at 06:01:39PM +0200, Kurt Garloff wrote:
> > OK will do. Simple enough ;-)
> > Any other comments on the patch?
> 
> Rediffed and put newlines before new sentences in the man page.

Sorry for being late, but this can't be done properly in vd.c, aspect.c
is the only place where it _can_ be done (not sure if _all_ necessary
information is available though), just try your patch with e.g.
-monitoraspect 0.3 and you'll see it does not work at all.
Also, the old behaviour should be kept as default.
In addition as I understood your description, avoiding aspect scaling is
not at all what you want, you want to avoid scaling if it makes little
difference.
In that case something like this:
> Index: libvo/aspect.c
> ===================================================================
> --- libvo/aspect.c      (revision 26401)
> +++ libvo/aspect.c      (working copy)
> @@ -96,6 +96,8 @@
>  #endif
>      }
>    }
> +  if (FFABS(*srch, aspdat.orgh) < 10) *srch = aspdat.orgh;
> +  if (FFABS(*srcw, aspdat.orgw) < 10) *srcw = aspdat.orgw;
>    aspdat.asp=*srcw / (float)*srch;
>  #ifdef ASPECT_DEBUG
>    printf("aspect(3) wh: %dx%d (org: %dx%d)\n",*srcw,*srch,aspdat.prew,aspdat.preh);

Seems to me more like what you want.

Greetings,
Reimar Döffinger