[MPlayer-dev-eng] [PATCH] [RESEND] -aspect-tolerenace option

Kurt Garloff kurt at garloff.de
Mon Apr 14 22:55:43 CEST 2008


Reimar,

> On Sat, Apr 12, 2008 at 10:40:45AM +0200, Reimar Döffinger wrote:
> > In that case something like this:
> > > Index: libvo/aspect.c
> > > ===================================================================
> > > --- libvo/aspect.c      (revision 26401)
> > > +++ libvo/aspect.c      (working copy)
> > > @@ -96,6 +96,8 @@
> > >  #endif
> > >      }
> > >    }
> > > +  if (FFABS(*srch, aspdat.orgh) < 10) *srch = aspdat.orgh;
> > > +  if (FFABS(*srcw, aspdat.orgw) < 10) *srcw = aspdat.orgw;
> > >    aspdat.asp=*srcw / (float)*srch;
> > >  #ifdef ASPECT_DEBUG
> > >    printf("aspect(3) wh: %dx%d (org: %dx%d)\n",*srcw,*srch,aspdat.prew,aspdat.preh);
> > 
> > Seems to me more like what you want.

Thanks for your patch. I think it helps when your output aspect is a
tiny bit off. However, it does not help my problem, when a rounding
error leads to the encoded movie not matching the recorded aspect
exactly:

garloff at core2:/usr/src/video/mplayer [1]$ ./mplayer -aspect-tolerance 0
/media/VIDEO-2/Trailer.avi
[...]
Starting playback...
VDec: vo config request - 1360 x 766 (preferred colorspace: Planar YV12)
VDec: using Planar YV12 as output csp (no 0)
Movie-Aspect is 1.78:1 - prescaling to correct movie aspect.
VO: [xv] 1360x766 => 1362x766 Planar YV12 
         ^^^^^^^^^^^^^^^^^^^^

I think both patches are needed.

Best,
-- 
Kurt Garloff                   <kurt at garloff.de>             [Koeln, DE]
Physics:Plasma modeling <garloff at plasimo.phys.tue.nl> [TU Eindhoven, NL]
Linux: VP PM OPS               <garloff at suse.de>            [Novell Inc]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080414/4ad6cead/attachment.pgp>


More information about the MPlayer-dev-eng mailing list