[MPlayer-dev-eng] [PATCH] Fix NULL pointer dereference when audio filter fails

compn tempn at twmi.rr.com
Tue Apr 29 18:14:02 CEST 2008


On Mon, 28 Apr 2008 18:40:20 +0300
Lasse Kärkkäinen <tronic+dm9n at trn.iki.fi> wrote:

> +      // FIXME: Possible leak: should something be uninitialized first?
> +      mpctx->sh_audio=mpctx->d_audio->sh=NULL; // failed to init  :( 

patch rejected, please find the bug instead of adding more hacks :)

uoti says:
<uau> Compn: it's not fully correct at least
<uau> as the comment in it says too

-compn



More information about the MPlayer-dev-eng mailing list