[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration

[Diego Biurrun]

On Tue, Aug 05, 2008 at 08:26:22PM -0400, compn wrote:
> On Sat, 2 Aug 2008 19:58:39 +0200, Diego Biurrun wrote:
> >Index: libvo/vo_x11.c
> >Index: libvo/vo_xvmc.c
> 
> patch missing configure check for removed declaration. rejected.

There is no configure check to begin with.  That's the whole point.
There are random prototypes duplicated over the code without any
assurance that the underlying libraries actually support them.
Thus the failure would just be moved from compile time to link time,
which is bad.

There is no indication where this declaration was ever missing on any
system except for the cryptic comment above it.  Log messages do not
enlighten us, neither does Google.  We do not know which systems are
affected.  In short, it is a mess and it is time to remove it.

Diego