[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration

[Attila Kinali]

On Sat, 2 Aug 2008 19:58:39 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> Here is a patch to remove a redundant XShmGetEventBase declaration from
> libvo/vo_x11.c and libvo/vo_xvmc.c, which dates back to r2(!).  If this
> is really a problem, there should be a proper check in configure, not a
> hackish declaration duplicated over multiple files.

As ex-ex-x11-maintainer i agree with the change and rational.
X11 related definitions belong to the X11 header files and nowhere
else. If some header file doesn't contain it, it is very likely that
the library doesn't provide the function. Thus, it is a question
whether it will fail at compile or link time. IMHO failure at compile
time is better.

And yes, if XShmGetEventBase is not declared on all systems
(which would surprise me as SHM is very old and the API stable),
then there should be a configure time check for it.

			Attila Kinali

-- 
A strange game.
The only winning move is not to play.
			-- Joshua, WarGames