[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration

[Ivan Kalvachev]

On 8/7/08, Attila Kinali <attila at kinali.ch> wrote:
> On Sat, 2 Aug 2008 21:42:22 +0300
> "Ivan Kalvachev" <ikalvachev at gmail.com> wrote:
>> Rejected.
>
> May i ask why you reject the patch?
> Is there anything technicaly wrong or is it just because
> it's Diego who wrote it?

let me quote you:
"[...] there should be a configure time check for it."

I'm not giving any reasons, because whatever reasons I give
Diego and Uoti would disband them as irrelevant and do
whatever they want anyway.
They've been doing this even without reasons.

e.g. The non-sense statement, that because this is somehow
related to building, then it is part of the build system and Diego's
responsibility. So everything that compiles is Diego's reign.
Is there something that is not covered by that? Documentation?
Documentation is his original reign.

BTW, video output system is as far away from the core as it is possible to be.

On 8/7/08, Attila Kinali <attila at kinali.ch> wrote:
> On Sat, 2 Aug 2008 19:58:39 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
>
>> Here is a patch to remove a redundant XShmGetEventBase declaration from
>> libvo/vo_x11.c and libvo/vo_xvmc.c, which dates back to r2(!).  If this
>> is really a problem, there should be a proper check in configure, not a
>> hackish declaration duplicated over multiple files.
>
> As ex-ex-x11-maintainer i agree with the change and rational.
> X11 related definitions belong to the X11 header files and nowhere
> else. If some header file doesn't contain it, it is very likely that
> the library doesn't provide the function. Thus, it is a question
> whether it will fail at compile or link time. IMHO failure at compile
> time is better.
>
> And yes, if XShmGetEventBase is not declared on all systems
> (which would surprise me as SHM is very old and the API stable),
> then there should be a configure time check for it.

XShm is not SHM even if they are 75% same by name and one uses the other ;)
I haven't blindly copied this declaration, I did checked if it is still needed.
It was. There were still systems with XFree86 4.1.x around.

Of course this argument would justify Diego urge to just remove it,
after all he is  known to remove solaris shell support right
after fixing it with user patch.

On top of that I think it is waste of time to argue about something
that is about removing/restoring useless warning.