[MPlayer-dev-eng] [PATCH] fix seeking in demux_lavf

[Aurelien Jacobs]

Uoti Urpala wrote:

> On Tue, 2008-08-12 at 05:17 +0200, Michael Niedermayer wrote:
> > Its not as if i would want some kind of monarchy, its just that half of
> > the new mails here where about a bunch of monkeys fighting about a piece of a
> > 7 year old banana while they had plenty of fresh ones.
> > Why exactly did diego fight so fiercely to remove 1 harmless line from
> > a file maintained by ivan?
> 
> What else do you suggest he could have done?

He could have added a check in configure as suggested. It may seem a bit
overkill, but it would have avoided any potential issue with old Xfree,
and it would have avoided flames.
Another possiblity would have been to simply disregard the harmless warning
generated by this line and switch to more important tasks.

> >  Have we run out of dirty code that needs to
> > be cleaned up And that can be cleaned up easily in a non provocative way?
> > Must be so ...
> 
> How was the way he did it provocative?

He committed, ignoring maintainer disagreement and braving rules.
This is provocative.

> He posted a patch, and if Ivan
> had any reasons why not to apply it he could have posted them.

I agree that Ivan could have been more explicit about the reason why
the patch wasn't acceptable in his first mail.
Still, he explicitly said (before Diego's commit) that the proper solution
would be a configure check.

Note that I don't care about the technical side of this issue.
But it feels very wrong to me to ignore maintainer's decision.
IMO, this has the same effect as svn rm DOCS/tech/MAINTAINERS.

Aurel