[MPlayer-dev-eng] Direct3D OSD discussion

[Jim Hauxwell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Georgi Petrov wrote:
> On Wed, Dec 3, 2008 at 1:44 PM, Reimar Döffinger
> <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
>> On Fri, Nov 28, 2008 at 11:15:12PM +0000, Jim Hauxwell wrote:
>>> OSD is a big patch and has required many goes from me to get the
>>> formatting correct etc.  I think it would be better to have a small
>>> patch to enhance the OSD later.
>> Well, if the vo_direct3d maintainer agrees with that I don't really have
>> a problem with it.
> 
> I absolutely agree that the patch should be included!!! I prefer to
> see the code and try to find problems/improve it myself and discuss it
> with Jim, who has the know-how.
> 
>> But there is one issue I just noticed that can't really be ignored
>> because I can not guarantee that it is not exploitable:
>> For a source video aspect < 1 the calc_height variable can be larger
>> than the OSD texture size, allowing to write beyond the bounds of the
>> texture memory buffer.
>>
> 
> Jim, can you fix it and submit the patch again?

I was going to change it based on the new stuff in the source tree.

I hope to have it complete later tonight, when I get a moment

Jim

> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkk4J20ACgkQhrNWoHjgI1CFGACdHD9mDDy/bG6DXWMK6uEZ5Epe
XBsAmgJGrEWa9clUeChhmD8KYOedMtEt
=ux2a
-----END PGP SIGNATURE-----