[MPlayer-dev-eng] [PATCH] libvo: set PBaseSize in SizeHints

[Reimar Döffinger]

On Fri, Dec 05, 2008 at 07:12:19PM +0100, Bert Wesarg wrote:
> Index: libvo/x11_common.c
> ===================================================================
> --- libvo/x11_common.c	(revision 28090)
> +++ libvo/x11_common.c	(working copy)
> @@ -1191,6 +1191,14 @@
>      vo_hint.flags |= PMinSize;
>      vo_hint.min_width = vo_hint.min_height = 4;
>  
> +    // per ICCCM 4.1.2.3: WMs should use the min size if the base size is
> +    // missing and are encouraged to present the width (height resp.) as
> +    // (width - base_width) / width_inc to the user. But we set the min size
> +    // to 4x4 which means the window size is improperly reported to the user
> +    vo_hint.flags |= PBaseSize | PResizeInc;
> +    vo_hint.base_width = vo_hint.base_height = 0;
> +    vo_hint.width_inc = vo_hint.height_inc = 1;

I applied the PBaseSize part. Unless there is a need to, I'd prefer not
to set PResizeInc.

Greetings,
Reimar Döffinger