[MPlayer-dev-eng] [PATCH] Direct3D blackborders proper alignment

[Reimar Döffinger]

On Mon, Dec 08, 2008 at 12:03:27PM +0200, Georgi Petrov wrote:
> I submit a patch in case we're in slave mode (WinID >= 0) and not in
> fullscreen. The problem is present when the window is resized to
> aspect different than the movie aspect. Then black borders should be
> added on left/right or up/bottom. Somehow MPUI and SMplayer manage to
> pass correct dimensions and add appropriate blackborders by
> themselves, but Vuze for example doesn't and this simple code fixes
> such frontends.

The behaviour is exactly as intended and Vuze must be fixed, not
MPlayer, with your proposed change _less_ functionality is available to
frontends, which is why it is wrong.
It is possible to provide a different mode in addition (I was thinking
of misusing vo_fs which currently has no meaning with -wid - except
for vo_directx which is broken in many ways)
If such a change needs to modify more than a few lines of code it is
still done wrong IMO, the same applies if -panscan does not work with
-wid then.

Greetings,
Reimar Döffinger