[MPlayer-dev-eng] [PATCH] Direct3D Much better D3D management

[Reimar Döffinger]

On Mon, Dec 08, 2008 at 12:18:12PM +0200, Georgi Petrov wrote:
> >> All these checks might be unnecessary.
> >> Also, if they are needed, what do you think about writing
> >>
> >>>     if (priv->d3d_backbuf)
> >>>         IDirect3DSurface9_Release(priv->d3d_backbuf);
> >>>     priv->d3d_backbuf = NULL;
> >>
> >> Instead? I cam to prefer it because
> >> 1) It is more obvious that priv->d3d_backbuf is always NULL afterwards
> >> 2) you save the {}, and essential it becomes just a "guard-if" for the
> >>   called function.
> >
> >
> > I understand. There's no difference for me, but I send a patch for all
> > deallocations in destroy_d3d_surfaces. Apply them if you like it
> > better.
> >
> 
> Did you forget this patch?

No, but there is more important stuff. Also there is no need for a
patch, making these modifications by hand does not even take one minute.

Greetings,
Reimar Döffinger