[MPlayer-dev-eng] [PATCH] Direct3D blackborders proper alignment

[Reimar Döffinger]

On Mon, Dec 08, 2008 at 01:33:59PM +0200, Georgi Petrov wrote:
> Ok, as it turned out, this patch is not supposed to go into MPlayer,
> so I consider this thread closed. Sorry guys, I was trying to help.

Your efforts are appreciated but please look at your patches before
sending them, thinking what someone who has no idea what you did would
think about them.
You should then notice things like e.g. that he will probably spend many
minutes just to find out that you only changed the indentation.
There are tools that help those reading patches to see such things, but
keep in mind that for popular parts of MPlayer it is still only one
person who has to take the time to prepare the patch but ten or more
people who read it. Improving patch readability costs one person's time,
and might save tens to hundreds of other people time, so do not include
"cosmetic" changes if they make your patch in any way harder to
understand.

Greetings,
Reimar Döffinger