[MPlayer-dev-eng] Direct3D OSD discussion

[Jim Hauxwell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Reimar Döffinger wrote:
> On Mon, Dec 08, 2008 at 12:00:52PM +0000, Jim Hauxwell wrote:
>> It should never go outside the texture area when generating the OSD
> 
> While that is true you fall back to using the whole texture, which i
> think is as in your very first patch, so the aspect issue should arise
> again.
> Setiing max_texture_width to 256 should help you see the issue if I am right.
> 

This is exactly what I did to test it.  Yes I agree the results for some
 really low end cards (which don't support decent texture sizes) wont be
ideal, but it will probably not affect 99% of people.  Also it shouldn't
now crash.  Ideally for a card which only supported say 1024 width, I
wanted to use the whole width to get the best OSD possible

>> @@ -397,7 +500,7 @@
>>      /* If we're here, then we should lock the rect and copy a packed frame */
>>      if (!priv->locked_rect.pBits) {
>>          if (FAILED(IDirect3DSurface9_LockRect(priv->d3d_surface,
>> -                                              &priv->locked_rect, NULL, 0))) {
>> +                                              &priv->locked_rect, NULL, D3DLOCK_DISCARD))) {
>>              mp_msg(MSGT_VO, MSGL_ERR, "<vo_direct3d>Surface lock failure\n");
>>              return VO_ERROR;
>>          }
> 
> Unrelated. If that is intentional and you explain the why i can make
> this change, you don't need to send a separate patch.

Sorry, I was playing elsewhere with some performance enhancing stuff.
It didn't actually make any noticeable difference on my card, so could
probably come out for now.  I'll go back to it later.

> 
>> @@ -530,9 +636,34 @@
>>      /* Store in priv->desktop_fmt the user desktop's colorspace. Usually XRGB. */
>>      priv->desktop_fmt = disp_mode.Format;
>>  
>> -    mp_msg(MSGT_VO, MSGL_V, "disp_mode.Width %d, disp_mode.Height %d\n",
>> +    mp_msg(MSGT_VO, MSGL_V, "<vo_direct3d>disp_mode.Width %d, disp_mode.Height %d\n",
>>             disp_mode.Width, disp_mode.Height);
> 
> Unrelated, remind me to fix it (at the latest) after the OSD was applied if I forget.

Will do

Patch attached with no intrinsics as per your last mail.

I am running this on Vista just FYI

Jim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkk9VrAACgkQhrNWoHjgI1DLcQCgj29GX0Q6aZcDvj5jYWv73urj
5RMAn1UA3D40e6rwq2QNM/hAGekpBnZV
=JZPU
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff21.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081208/8fff70eb/attachment.txt>