[MPlayer-dev-eng] [PATCH] multi language part 1/2

[Diego Biurrun]

On Tue, Dec 09, 2008 at 11:43:24PM +0100, Ötvös Attila wrote:
> Ezzel a dátummal: Tuesday 09 December 2008 20:49:41 Diego Biurrun ezt írta:
> 
> > This patch is huge and does many different things, as your patches
> > always seem to.  Could you please split this into small self-contained
> > pieces?  Otherwise this will be impossible to manage and review.
> 
> Ok. I splited patch:
> 
> 01-01-mp_msg_fixed.patch:
> This patch fixed double " string terminator and
> change MGSTR_* to MSGTR_*
> (12x help_mp-*.h)

I already made this change.

> 01-03-remove-static-string-cat.patch:
> This patch removed static string cat

Why?

> 01-04-remove-spaces-string.patch:
> This patch removed spaces string from gui/mplayer/gtk/menu.c

Why?

> 01-05-remove-static-string-cat-about.patch:
> This patch removed static string cat from gui/mplayer/gtk/about.c

Why?

Note that I'm not against these patches, I'd just like to hear some
reasoning for them.

Diego