[MPlayer-dev-eng] [PATCH] vo_macosx: option to set shared buffer name to allow multiple instances

[Uoti Urpala]

On Wed, 2008-12-10 at 10:26 +0100, Reimar Döffinger wrote:
> On Tue, Dec 09, 2008 at 03:20:58PM +0100, Adrian Stutz wrote:
> > 1: vo_macosx_subopt_parsing.patch
> > Changes vo_macosx's custom subopt parsing to subopt_parse().
> 
> One minor comment: the subopt parser will always use 0/1 for bool
> variables, so using "false" might not be such a good idea (it adds the
> implicit assumption that "false" is always 0). But if you think the
> readability advantage is worth it you can of course leave it in.

In C "false" is always 0, and that's something you _should_ assume. I
doubt that differs in Objective-C (I assume the "false" used here is
part of Objective-C). In C booleans are not even meant to be a
completely separate type. Choosing whether to write "0" and "1" or
"false" and "true" is always only about code readability and making the
semantics obvious, and much of the time that is also true about choosing
whether to make the type of a variable "bool".