[MPlayer-dev-eng] [PATCH] Direct3D Smooth (delayed) resize

[Reimar Döffinger]

On Wed, Dec 10, 2008 at 02:56:15PM +0200, Georgi Petrov wrote:
> Back on the topic: What exactly you don't like about the patch? It's
> perfectly fine IMHO. I don't do anything bad.

Well, firstly I do not see a good reason for the -wid special-case:
either the flicker is annoying or it is not, whether SMPlayer is used or
not is not relevant. Such inconsistencies in behaviour are also a major
pain for long-term maintenance, for example because it means when a user
reports "video breaks when resizing" you now have to ask if they use
a Gui, because you use different code then.
Secondly, I think we agree that it is not a perfect solution (I'd tend
to even call it a hack) so I wanted to be sure you looked enough that
we can be reasonably sure there is no better solution.
Thirdly, it could be considered a bug workaround. I don't think there is
any technical necessity why the driver could not reset, reinitialize and
redraw in such a way that it is impossible to notice and gets at least
25 fps with current hardware. Under this aspect, since what your patch
is non-optional it makes those with good drivers (which admittedly
may not exist) suffer just because most drivers are bad.

And no, I don't claim the patch is bad. But I think you can do at least
a bit better, and possibly even a lot better.

Greetings,
Reimar Döffinger