[MPlayer-dev-eng] pkgconfig's cflags honoring (was: Re: [PATCH] Fix compilation on OpenBSD)

[Diego Biurrun]

On Sat, Nov 29, 2008 at 11:27:05AM +0100, Diego Biurrun wrote:
> On Sat, Nov 29, 2008 at 12:09:51AM +0300, Andrew Savchenko wrote:
> > 
> > On Friday 28 November 2008 12:41, Diego Biurrun wrote:
> > [...]
> > > > +  test $_pkg_config == "false" || _inc_theora="`$_pkg_config
> > > > --silence-errors --cflags theora`"
> > >
> > > Using == in 'test' invocations is a bashism.
> > >
> > > Also, the value of _pkg_config is the *program* false, so that
> > > all invocations of pkg-config via $_pkg_config will simply fail
> > > cleanly.  So you can simply execute the command and react
> > > according to the return value.
> > 
> > Return value check is the same as previos solution in terms of 
> > complexity, but if in your opinion check of return value is more 
> > elegant solution, so it should be.
> 
> Look at how some of the other pkg-config tests are done in configure.
> 
> Anyway, the whole Theora test in configure looks quite crufty and
> suspicious.  I think it needs to be rewritten.

Test rewritten.  Let me know if you still experience issues.

Diego