[MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

[Guillaume POIRIER]

Hello,

On Mon, Dec 15, 2008 at 11:14 PM, Chris Roccati <roccati at pobox.com> wrote:
> On 15 Dec 2008, at 22:24 , Guillaume POIRIER wrote:
>> Could you give me a test case so that I can check the behavior before
>> and after the patch?
>
> You need to wrap the executable in an application bundle, with an
> Info.plist defining atleast one supported file type; then you will be
> able to open that file type with mplayer using the "Open With"
> context menu.
>
> If you remove QuitApplicationEventLoop() the mplayer icon (whatever
> you provided in the application bundle) will appear in the dock, but
> mplayer will start playing the file after selecting "Quit MPlayer"
> from the "MPlayer" menu. If you leave the code as-is, the playback
> will start (as expected) immediately.

I see. That's indeed not the behavior the user would expect.


> If you need it, I can directly send you the application bundle with
> everything but the mplayer executable.

Yep, please do so. I have exactly zero knowledge on that part of OSX
programming. Could you direct me to some documentation about that?


>> In any case, something will have to be made about that piece of code,
>> since it is not 64-bits friendly as is.
>
> I will check what the options are, but I'm still using MacOS 10.4.x
> (with a powermac G5).

Ok, very good. My PPC machine is running Tiger too. My laptop uses
Leopard though.

Guillaume
-- 
Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Bob Hope  - "I don't feel old. I don't feel anything till noon. That's
when it's time for my nap."