[MPlayer-dev-eng] [PATCH]Allow 32bit compilation on 64bit OS

[Reimar Döffinger]

On Fri, Dec 19, 2008 at 08:27:13PM +0100, Diego Biurrun wrote:
> On Fri, Dec 19, 2008 at 02:14:56PM +0100, Carl Eugen Hoyos wrote:
> >
> > I needed attached patch to play WMA9 files.
> >
> > Please comment, Carl Eugen
> >
> > --- configure	(revision 28162)
> > +++ configure	(working copy)
> > @@ -1340,7 +1340,7 @@
> >        x86_64|amd64)
> >          if [ -n "`$_cc -dumpmachine | sed -n '/^x86_64-/p;/^amd64-/p'`" -a \
> > -             -z "`echo $CFLAGS | grep -- -m32`"  ]; then
> > +             -z "`echo $_cc | grep -- -m32`"  ]; then
> 
> I don't see how this can be equivalent, _cc should not contain any
> CFLAGS.  What is the exact purpose of your patch?

While I see your point, overriding CFLAGS is a huge pain, you have to
remember to set march, mcpu, -O3, -fomit-frame-pointer and hell knows
what.
So I'd be in favour of supporting "gcc -m32" as cc in addition (i.e.
adding
-a -z "`echo $_cc | grep -- -m32`" 
instead of replacing the CFLAGS check.