[MPlayer-dev-eng] [PATCH] vo_macosx: option to set shared buffer name to allow multiple instances

[Diego Biurrun]

On Fri, Dec 19, 2008 at 10:14:55PM +0100, Guillaume POIRIER wrote:
> 
> On Fri, Dec 19, 2008 at 10:02 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Fri, Dec 19, 2008 at 09:34:26PM +0100, Guillaume POIRIER wrote:
> >>
> >> On Tue, Dec 9, 2008 at 3:20 PM, Adrian Stutz <adrian at sttz.ch> wrote:
> >> > On Tue, Dec 9, 2008 at 2:49 PM, Guillaume POIRIER <poirierg at gmail.com>wrote:
> >> >
> >> >> Yep, please both split and _attach_ the patch ;-)
> >> >
> >> > Ok, patch splitted.
> >> >
> >> > 1: vo_macosx_subopt_parsing.patch
> >> > Changes vo_macosx's custom subopt parsing to subopt_parse().
> >>
> >> Patch applied, thanks!
> >
> > No, you applied only the code part.  But I see that the documentation
> > part of this patch is merged into another patch, i.e. it's a total
> > mess.
> 
> I beg you pardon? The code I applied _strictly_ changed the custom
> parsing by subopts parser.
> The undocumented option shared_buffer as already supported before that
> patch was applied.
> 
> Getting it documented is a completely different matter than changing
> the way the options are parsed!

Sorry, I misread your patch then.

> > Get this sorted out!
> 
> Can't you ask that in a more polite way?

I got carried away, you know I get upset when the docs get out of sync
with the code due to the amount of work I put into syncing them in the
first place.  My apologies.

Diego