[MPlayer-dev-eng] [PATCH v2] support sub_pos in libass

[Rafał Miłecki]

2008/12/25 Evgeniy Stepanov <eugeni.stepanov at gmail.com>:
> On Wednesday 24 December 2008 20:22:10 Rafał Miłecki wrote:
>> OK, I tried to fix reported issues and hopefully done it right.
>>
>> Is this one acceptable?
>>
>> 01 and 02 touch libass only. 03 makes use of this new feature which is
>> sub_precentpos :)
>
> Why do you change sub_percentpos in ass_start_frame??
> And why is it in global_settings, and not in ass_style_t?

It's just a little hack to make sure sub_percentpos will be set
(instead of leaving in uninitialized). Did you check patch 02...? It
removes that hackish way of setting sub_percentpos.


> Also, I think you don't need ass_sub_percentpos in ass_mp.c. You can use
> sub_pos directly.

Please, read discussion in previous thread. libass is not mplayer-only
library, it has to compile also in other projects. sub_pos is mplayer
specific variable.


> And 14 should be VALIGN_PERCENTPOS | HALIGN_CENTER.

There you're right. That will make code cleaner. Thanks.


Any other comments on my patch? :) I wish to make final version of
patch (fixing " = 14") and ask to push it into mainline.

-- 
Rafał Miłecki