[MPlayer-dev-eng] [PATCH] fix flickering OSD with tfields, yadif

[Uoti Urpala]

On Sat, 2008-12-27 at 20:28 +0100, Reimar Döffinger wrote: 
> On Sat, Dec 27, 2008 at 07:03:18PM +0200, uoti.urpala at pp1.inet.fi wrote:
> > Reimar Döffinger wrote:
> > > How in the world is -correct-pts supposed to change the fact that
> > > draw_osd is only called for every second frame, and thus the OSD is only
> > > drawn on every second frame?
> > 
> > Filters adding frames is supported in that case. The added frames are handled
> > normally by core code and should not differ from OSD point of view.
> 
> Well, obviously once more "how it is supposed to work" has not survived
> the impact of reality.

Filters in general seem to get very little use/testing nowadays.

> I'm not sure if it is less ugly to move this into mplayer.c instead so
> it is not duplicated, but this patch fixes the -correct-pts case:

I think I'll move that logic to mplayer.c. 

> However I see no reason to leave the other case broken.

Doing flip calls from inside filters is extremely hacky IMO, and it
still leaves at least timing and frame stepping broken. Given how little
testing this seems to get it's likely break worse at some point. 

I was going to change the frame creation logic to always behave more
like the correct-pts case anyway because of the pause changes (to ensure
that a frame from the new position is always shown when seeking while
paused); I can probably do it in a way that allows the same filter
functionality too.