[MPlayer-dev-eng] [PATCH] support run command with specific osd_level

[Ulion]

2008/1/31, Uoti Urpala <uoti.urpala at pp1.inet.fi>:
> On Wed, 2008-01-30 at 21:51 +0800, Ulion wrote:
> > ok, check this
>
> The new status variables should be mpctx fields, not globals.
>
> -            if (osd_level == 3)
> +            if (osd_level == 3 ||
> +                    (mpctx->osd_show_percentage && force_seek_osd_level >= 3))
>
> Code like this assumes a particular implementation of other OSD
> functionality (that nothing but seeks sets osd_show_percentage) and
> makes it harder to change. In general this makes OSD handling more
> complex. I think it at least needs a good justification. What kind of
> use cases do you have for this functionality?

osd_level is global, so I make force_osd_level and
force_seek_osd_level be global. then should all of them be made as
member of mpctx?

mpctx->osd_show_percentage is only used by SEEK command in command.c,
this code is only used for display percentage for 1 second after a
seek. If some code want to use mpctx->osd_show_percentage in future
for non-seek function, it should settle problems such as
justification. From where code you referred, can not judge who at
where set the mpctx->osd_show_percentage, so any better idea?


-- 
Ulion