[MPlayer-dev-eng] [PATCH] wid support with vo_sdl

[Ricardo Salveti]

On Wed, Jun 25, 2008 at 8:20 AM, Aurelien Jacobs <aurel at gnuage.org> wrote:
>> diff -Naur mplayer-trunk-old/libvo/vo_sdl.c mplayer-trunk-new/libvo/vo_sdl.c
>> --- mplayer-trunk-old/libvo/vo_sdl.c  2008-06-25 01:20:51.000000000 -0300
>> +++ mplayer-trunk-new/libvo/vo_sdl.c  2008-06-25 02:36:20.000000000 -0300
>> @@ -793,12 +793,22 @@
>>           return -1;
>>
>>       /* Set output window title */
>> -     SDL_WM_SetCaption (".: MPlayer : F = Fullscreen/Windowed : C = Cycle Fullscreen Resolutions :.", title);
>> +    if (WinID < 0)
>> +        SDL_WM_SetCaption (".: MPlayer : F = Fullscreen/Windowed : C = Cycle Fullscreen Resolutions :.", title);
>
> Cosmetics.
> (you shouldn't mix cosmetics and functionnal changes, which means, don't
> reindent lines that you don't touch otherwise)

Fixed.

>> -     aspect_save_screenres(priv->XWidth,priv->XHeight);
>> -     aspect(&priv->dstwidth,&priv->dstheight,A_NOZOOM);
>> +        aspect_save_screenres(priv->XWidth,priv->XHeight);
>> [...]
>> +        aspect(&priv->dstwidth,&priv->dstheight,A_NOZOOM);
>
> Cosmetics.

Fixed.

Here's the third version of the patch, without these cosmetics changes.

Thanks for reviewing the patch.

Regards,
-- 
Ricardo Salveti de Araujo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-vo_sdl-wid-v3.patch
Type: text/x-patch
Size: 3899 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080625/580eb371/attachment.bin>